Comments on: Deleting DOM nodes with Dojo http://shaneosullivan.wordpress.com/2009/01/02/deleting-dom-nodes-with-dojo/ Shane O'Sullivan's technical blog... really ties the room together Sat, 14 Nov 2009 22:59:04 +0000 http://wordpress.com/ hourly 1 By: Peter Higgins http://shaneosullivan.wordpress.com/2009/01/02/deleting-dom-nodes-with-dojo/#comment-8757 Peter Higgins Sat, 03 Jan 2009 02:15:56 +0000 http://shaneosullivan.wordpress.com/?p=196#comment-8757 while(n.lastChild){ n.removeChild(n.lastChild); } is faster to empty a node. removeChild however doesn't destroy, just leaves them in limbo. But i've been wrong before ... while(n.lastChild){ n.removeChild(n.lastChild); } is faster to empty a node. removeChild however doesn’t destroy, just leaves them in limbo. But i’ve been wrong before …

]]> By: Nathan Toone http://shaneosullivan.wordpress.com/2009/01/02/deleting-dom-nodes-with-dojo/#comment-8756 Nathan Toone Sat, 03 Jan 2009 00:58:34 +0000 http://shaneosullivan.wordpress.com/?p=196#comment-8756 I want in... Isn't there an error in your "original" (non-Dojo) code? You said: if (node) { node.parentNode.removeChild(node); } But it probably should be: if (node && node.parentNode) { node.parentNode.removeChild(node); } :) I want in…

Isn’t there an error in your “original” (non-Dojo) code?

You said:

if (node) {
node.parentNode.removeChild(node);
}

But it probably should be:

if (node && node.parentNode) {
node.parentNode.removeChild(node);
}

:)

]]> By: Shane O'Sullivan http://shaneosullivan.wordpress.com/2009/01/02/deleting-dom-nodes-with-dojo/#comment-8755 Shane O'Sullivan Sat, 03 Jan 2009 00:57:05 +0000 http://shaneosullivan.wordpress.com/?p=196#comment-8755 Also, dojo._destroyElement does not do a null check, so the code in comments #4 and #5 would break if any of the nodes didn't exist. Perhaps the dojo.destroy method in 1.3 will do a null check, but if not, it won't work either. I've updated the post with a new method of deleting nodes, based on Pete's information that there is a bug in Dojo that means if searching for "#node1, #node2" and "node1" doesn't exist, "node2" isn't found and removed. The updated code gets around this bug. Also, dojo._destroyElement does not do a null check, so the code in comments #4 and #5 would break if any of the nodes didn’t exist. Perhaps the dojo.destroy method in 1.3 will do a null check, but if not, it won’t work either.

I’ve updated the post with a new method of deleting nodes, based on Pete’s information that there is a bug in Dojo that means if searching for “#node1, #node2″ and “node1″ doesn’t exist, “node2″ isn’t found and removed.

The updated code gets around this bug.

]]> By: Peter Higgins http://shaneosullivan.wordpress.com/2009/01/02/deleting-dom-nodes-with-dojo/#comment-8754 Peter Higgins Sat, 03 Jan 2009 00:53:22 +0000 http://shaneosullivan.wordpress.com/?p=196#comment-8754 okay, to work around any potential unexpected behavior as a result of #7125 (open as of 1.3): dojo.forEach(nodesIds, function(sel){ dojo.query(sel).forEach(dojo.destroy); }); okay, to work around any potential unexpected behavior as a result of #7125 (open as of 1.3):

dojo.forEach(nodesIds, function(sel){ dojo.query(sel).forEach(dojo.destroy); });

]]> By: Peter Higgins http://shaneosullivan.wordpress.com/2009/01/02/deleting-dom-nodes-with-dojo/#comment-8753 Peter Higgins Sat, 03 Jan 2009 00:37:22 +0000 http://shaneosullivan.wordpress.com/?p=196#comment-8753 it is a little known fact dojo.destory is an undocumented alias to dojo._destroyElement. Always has been. I win. (/me jokes) it is a little known fact dojo.destory is an undocumented alias to dojo._destroyElement. Always has been. I win. (/me jokes)

]]> By: Shane O'Sullivan http://shaneosullivan.wordpress.com/2009/01/02/deleting-dom-nodes-with-dojo/#comment-8752 Shane O'Sullivan Sat, 03 Jan 2009 00:35:46 +0000 http://shaneosullivan.wordpress.com/?p=196#comment-8752 if it weren't for the error your code would throw, I'd agree :-) dojo.query(nodeIDs.join(”,”)).forEach(dojo.destroy); I WIN!! ;-) if it weren’t for the error your code would throw, I’d agree :-)

dojo.query(nodeIDs.join(”,”)).forEach(dojo.destroy);

I WIN!! ;-)

]]> By: Peter Higgins http://shaneosullivan.wordpress.com/2009/01/02/deleting-dom-nodes-with-dojo/#comment-8751 Peter Higgins Sat, 03 Jan 2009 00:33:43 +0000 http://shaneosullivan.wordpress.com/?p=196#comment-8751 okay I win: dojo.query(nodeIDs.join(",")).forEach(dojo.destory); okay I win:

dojo.query(nodeIDs.join(“,”)).forEach(dojo.destory);

]]> By: Shane O'Sullivan http://shaneosullivan.wordpress.com/2009/01/02/deleting-dom-nodes-with-dojo/#comment-8750 Shane O'Sullivan Sat, 03 Jan 2009 00:32:43 +0000 http://shaneosullivan.wordpress.com/?p=196#comment-8750 or dojo.forEach(dojo.query(nodeIDs.join), dojo._destroyElement); or

dojo.forEach(dojo.query(nodeIDs.join), dojo._destroyElement);

]]> By: Shane O'Sullivan http://shaneosullivan.wordpress.com/2009/01/02/deleting-dom-nodes-with-dojo/#comment-8749 Shane O'Sullivan Sat, 03 Jan 2009 00:20:34 +0000 http://shaneosullivan.wordpress.com/?p=196#comment-8749 Both good solutions Pete, but my one is a better general purpose solution I think, since as you point out, you can use the full CSS selector syntax. A combined solution could be: // v1.2 dojo.query(nodeIDs.join(",")).forEach("dojo._destroyElement(item)"); // v1.3 dojo.query(nodeIDs.join(",")).forEach("dojo.destroy(item)"); Both good solutions Pete, but my one is a better general purpose solution I think, since as you point out, you can use the full CSS selector syntax.

A combined solution could be:

// v1.2
dojo.query(nodeIDs.join(“,”)).forEach(“dojo._destroyElement(item)”);

// v1.3
dojo.query(nodeIDs.join(“,”)).forEach(“dojo.destroy(item)”);

]]> By: Peter Higgins http://shaneosullivan.wordpress.com/2009/01/02/deleting-dom-nodes-with-dojo/#comment-8748 Peter Higgins Fri, 02 Jan 2009 23:49:02 +0000 http://shaneosullivan.wordpress.com/?p=196#comment-8748 how about: dojo.forEach(["node1","node2","node3"], dojo._destroyElement); or in 1.3: dojo.forEach(["node1","node2","node3"], dojo.destroy); (clearly it won't work in the class-name-looking scenario though) how about:

dojo.forEach(["node1","node2","node3"], dojo._destroyElement);

or in 1.3:

dojo.forEach(["node1","node2","node3"], dojo.destroy);

(clearly it won’t work in the class-name-looking scenario though)

]]>